Fix nonblocking dispatch watcher polling#10
Open
amittell wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the dispatch delivery watcher to detect and fail “running” labels whose underlying agent sessions have stalled (even when the watcher heartbeat is still fresh), while avoiding false failures during long-running tool calls by inspecting the JSONL transcript tail.
Changes:
- Add stall detection for running sessions using sessions.json + JSONL activity signals and fail the label with a clear error summary.
- Add a JSONL-tail check to detect pending tool handoffs even when transcript mtime is flat.
- Persist an
errorfield when marking labels aserror, and add a lightweight regression test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
dispatch/watcher.mjs |
Adds stall detection, pending-tool safeguards, and records entry.error when failing a label. |
tests/delivery-fixes.test.mjs |
Adds a regression test ensuring the new watcher stall-detection hooks are present. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amittell
force-pushed
the
fix-dispatch-stale-agent-session
branch
from
65666fe to
6b2eca8
Compare
amittell
force-pushed
the
fix-dispatch-stale-agent-session
branch
from
6b2eca8 to
2b242a8
Compare
amittell
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
node --test tests/delivery-fixes.test.mjscd ~/.openclaw/chilisaus && node --test tests/watcher.test.mjs tests/watcher-delivery.test.mjs tests/status-liveness.test.mjsSCHEDULER_DB=:memory: node test.jsnode --checkon touched source and active runtime watcher filesgit diff --checkNo gateway or scheduler restart performed.